Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deprecate public orders #81

Merged
merged 4 commits into from
Feb 27, 2025
Merged

refactor: Deprecate public orders #81

merged 4 commits into from
Feb 27, 2025

Conversation

JohnPhamous
Copy link
Contributor

No description provided.

Copy link

semanticdiff-com bot commented Feb 27, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  package.json  98% smaller
  src/lib/orders/index.tsx  78% smaller
  src/lib/orders/OrderDisplay.tsx  0% smaller

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR deprecates the public orders feature in the CLI, making it no longer possible to view public orders.

  • Modified --public option in src/lib/orders/index.tsx to indicate it's deprecated and hardcoded include_public: false in the getOrders function
  • Removed UI element in src/lib/orders/OrderDisplay.tsx that showed users how to view public standing orders
  • There's a typo in the order cancellation request header where "Content-Type" is misspelled as "Content-ype"
  • The PR includes code quality improvements like replacing parseInt with Number.parseInt and better code formatting

3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@JohnPhamous JohnPhamous merged commit 72a9d28 into main Feb 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant